[PATCH] D39304: [IR] redefine 'reassoc' fast-math-flag and add 'trans' fast-math-flag

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 27 19:08:33 PDT 2017


hfinkel added inline comments.


================
Comment at: docs/LangRef.rst:2304
+``afn``
+   Approximate functions represented by LLVM intrinsics or math libraries 
+   (sin, log, sqrt, etc). See floating-point intrinsic definitions for places 
----------------
I think that we should essentially use Andrew's proposed definition here:

  Allow substitution of approximate calculations for functions (e.g., sin, log, sqrt).


================
Comment at: docs/LangRef.rst:10498
+floating point number. When specified with the fast-math-flag 'afn', the
+result may not match a conforming libm implementation. 
 
----------------
This conformance language is only necessary for sqrt. For the other functions, there is no standard for their accuracy/precision. You might say that with 'afn' the result may not match what would have been returned by the system's libm implementation.


https://reviews.llvm.org/D39304





More information about the llvm-commits mailing list