[PATCH] D39132: [llvm-objcopy] Fix bug in how segment alignment was being handled

Fri Oct 27 14:08:59 PDT 2017

jakehehrlich added a comment.

In https://reviews.llvm.org/D39132#903387, @jhenderson wrote:

> You should probably have a test for the BinaryObject case as well.
>
> > In fact yaml2obj can't even produce a valid situation which causes llvm-objcopy to produce incorrect results because alignment and offset were both inherited from the sections the program header covers
>
> Could you explain a bit more what you mean by this? The p_align field for a segment should be completely independent of the align field of its sections.

I think this should be the case but I settled for allowing it to be computed from the sections at the request of the reviewer. I have a change in yaml2obj to make this the case up for review. Hopefully it gets reviewed soon.

Repository:
  rL LLVM

https://reviews.llvm.org/D39132