[PATCH] D39373: Reorder Value.def to optimize code size

[Noel Grandin via Phabricator via llvm-commits]

grandinj added inline comments.


================
Comment at: include/llvm/IR/Value.def:59
 
-HANDLE_VALUE(Argument)
-HANDLE_VALUE(BasicBlock)
-
-// FIXME: It's awkward that Value.def knows about classes in Analysis. While
-// this doesn't introduce a strict link or include dependency, we should remove
-// the circular dependency eventually.
-HANDLE_MEMORY_VALUE(MemoryUse)
-HANDLE_MEMORY_VALUE(MemoryDef)
-HANDLE_MEMORY_VALUE(MemoryPhi)
+// Having constant first makes the range check for isa<Consant> faster
+// and smaller by one operation.
----------------
Consant -> Constant


Repository:
  rL LLVM

https://reviews.llvm.org/D39373