[PATCH] D39355: [dsymutil] Implement the --threads option

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 27 11:15:48 PDT 2017


JDevlieghere added inline comments.


================
Comment at: tools/dsymutil/dsymutil.cpp:365
+      else
+        Threads.async(LinkLambda);
 
----------------
vsk wrote:
> Wdyt of wrapping the ThreadPool in a helper class that only constructs the pool if NumThreads > 1? It's not a big deal, but it's strange to me that we'd spawn/tear down a thread but never use it.
I'd prefer not to do this, as this should really only be a temporary workaround util the recursion stuff is fixed. 


Repository:
  rL LLVM

https://reviews.llvm.org/D39355





More information about the llvm-commits mailing list