[PATCH] D39304: [IR] redefine 'reassoc' fast-math-flag and add 'trans' fast-math-flag

[Sanjay Patel via Phabricator via llvm-commits]

spatel updated this revision to Diff 120647.
spatel marked 4 inline comments as done.
spatel added a comment.

Patch updated:

1. Changed 'AllowTrans' to 'AllowMathLib' and 'trans' to 'aml'. The IR abbreviation is more alphabet soup, but less "awkward morning" than 'amlib' - still open to suggestions :)
2. Updated LangRef with suggested fixes. Trying to toe the weasel-word line here with enough ambiguity to accomplish transforms but not be completely meaningless.
3. Removed 'TODO' comments at uses of isFast() / setFast(). We can just grep those calls and fix them.
4. Added a variant of the 'fast' means all flags test from https://reviews.llvm.org/D39319.


https://reviews.llvm.org/D39304

Files:
  docs/LangRef.rst
  include/llvm/IR/Instruction.h
  include/llvm/IR/Operator.h
  include/llvm/Transforms/Utils/LoopUtils.h
  lib/AsmParser/LLLexer.cpp
  lib/AsmParser/LLParser.h
  lib/AsmParser/LLToken.h
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/CodeGen/ExpandReductions.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/Instruction.cpp
  lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
  lib/Target/AMDGPU/AMDGPULibCalls.cpp
  lib/Transforms/InstCombine/InstCombineAddSub.cpp
  lib/Transforms/InstCombine/InstCombineCalls.cpp
  lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
  lib/Transforms/Scalar/Reassociate.cpp
  lib/Transforms/Utils/LoopUtils.cpp
  lib/Transforms/Utils/SimplifyLibCalls.cpp
  lib/Transforms/Vectorize/LoopVectorize.cpp
  lib/Transforms/Vectorize/SLPVectorizer.cpp
  test/Assembler/fast-math-flags.ll
  test/Bitcode/compatibility-3.6.ll
  test/Bitcode/compatibility-3.7.ll
  test/Bitcode/compatibility-3.8.ll
  test/Bitcode/compatibility-3.9.ll
  test/Bitcode/compatibility-4.0.ll
  test/Bitcode/compatibility-5.0.ll
  test/Bitcode/compatibility.ll
  unittests/IR/IRBuilderTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39304.120647.patch
Type: text/x-patch
Size: 53689 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171027/3bd2dc2e/attachment-0001.bin>