[PATCH] D33155: [DWARFv5] Support FORM_strp in the line table header

[Paul Robinson via Phabricator via llvm-commits]

probinson updated this revision to Diff 120642.
probinson added a comment.
Herald added subscribers: JDevlieghere, emaste.

By passing a DWARFUnit into the line-table parser (if we have one), we allow it to handle indirect string forms, which require finding other sections.  Previously the line-table parser couldn't do that (and didn't need to, prior to v5).
By passing DWARFFormParams to DWARFFormValue::extractValue() separately from the DWARFUnit, we allow interpreting forms according to the line-table's version/format, which could be different from the Unit's version/format.

This doesn't do the .dwo part yet, I'd like to leave that for a follow-up.


https://reviews.llvm.org/D33155

Files:
  lld/ELF/InputFiles.cpp
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFFormValue.h
  llvm/lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp
  llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
  llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp
  llvm/test/DebugInfo/Inputs/dwarfdump-header-64.elf-x86-64
  llvm/test/DebugInfo/Inputs/dwarfdump-header-64.s
  llvm/test/DebugInfo/Inputs/dwarfdump-header.elf-x86-64
  llvm/test/DebugInfo/Inputs/dwarfdump-header.s
  llvm/test/DebugInfo/dwarfdump-header-64.test
  llvm/tools/dsymutil/DwarfLinker.cpp
  llvm/unittests/DebugInfo/DWARF/DWARFFormValueTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33155.120642.patch
Type: text/x-patch
Size: 22001 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171027/df7373d7/attachment.bin>