[PATCH] D38631: [SimplifyCFG] use pass options and remove the latesimplifycfg pass

[Balaram Makam via Phabricator via llvm-commits]

bmakam added inline comments.


================
Comment at: include/llvm/Transforms/Scalar.h:263
+    bool ConvertSwitch = false, bool KeepLoops = true,
+    std::function<bool(const Function &)> Ftor = nullptr);
 
----------------
We still pass boolean and values to createCFGSimplificationPass(1, false, false, true) Don't we need builder API here as well?


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:630
+  // canonical by other IR passes.
+  MPM.add(createCFGSimplificationPass(1, true, true, false));
   addInstructionCombiningPass(MPM);
----------------
We still pass booleans and values here. See my comment above for builder API.


https://reviews.llvm.org/D38631