[PATCH] D39059: [X86][AVX] Update VCVTx, VMOVNTPx and VROUNDYPx instructions scheduling on btver2

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ScheduleBtVer2.td:544
+
+def Write32Ld: SchedWriteRes<[JLAGU, JSTC]> {
+  let Latency = 8;
----------------
Please rename these WriteVCVTY / WriteVCVTYLd  (or something similar). I think you can put the VCVTPS2DQ instructions in here as well?


================
Comment at: lib/Target/X86/X86ScheduleBtVer2.td:555
+}
+def : InstRW<[WriteVMONTPSt], (instregex "VMOVNTP(S|D)Ymr")>;
+
----------------
Can you add VMOVNTDQYmr as well? Even though we don't test for it properly due to domain issues.....


================
Comment at: lib/Target/X86/X86ScheduleBtVer2.td:576
+def WriteVCVTPSYLd: SchedWriteRes<[JLAGU, JSTC]> {
+  let Latency = 11;
+  let ResourceCycles = [1, 2];
----------------
This should be 8? Anyway, the VCVTPS2DQ can be merged with VCVTDQ2PD/VROUND above


https://reviews.llvm.org/D39059