[PATCH] D39364: [Polly][acc] Do not statically dispatch into IslNodeBuilder's createFor

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 27 02:39:30 PDT 2017


philip.pfaffe added inline comments.


================
Comment at: include/polly/CodeGen/IslNodeBuilder.h:354
   void createForVector(__isl_take isl_ast_node *For, int VectorWidth);
-  void createForSequential(__isl_take isl_ast_node *For, bool KnownParallel);
+  void createForSequential(__isl_take isl_ast_node *For, bool MarkParallel);
 
----------------
Meinersbur wrote:
> Is there some change of meaning to the second argument, or why renaming it?
Yes, the meaning changed. Before, `KnownParallel` was used as a hint to determine whether the created loop should be marked parallel by the Annotator. This analysis now happens in `IslNodeBuilder::createFor` and is then passed into this method here.


https://reviews.llvm.org/D39364





More information about the llvm-commits mailing list