[PATCH] D38971: Enhance libsanitizer support for invalid-pointer-pair.

Martin Liška via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 27 01:43:12 PDT 2017


marxin added a comment.

In https://reviews.llvm.org/D38971#908129, @kcc wrote:

> In https://reviews.llvm.org/D38971#907748, @marxin wrote:
>
> > I'll do it in a separate patch.
> >  Can you please @kcc explain me how should I use the lock for stack access in order to have it less locking?
> >  I'm planning also to come up with a multi-threaded test-case.
>
>
> Please just don't do it in this patch -- no locking, no checking of other thread's stacks.


Ok, so now we check pointers in shadow memory for size <= 2048. If we don't want to grab the lock, FindThreadByStackAddress can't be used.
And thus AddrIsInStack can't be used. So do you prefer not to use it and stay with the shadow memory iteration?


https://reviews.llvm.org/D38971





More information about the llvm-commits mailing list