[PATCH] D38898: [SelectionDAG] Add MachineMemOperand flags to the NodeID for MemSDNodes

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 21:13:13 PDT 2017


sfertile added a comment.

In https://reviews.llvm.org/D38898#908836, @hfinkel wrote:

> LGTM
>
> Also, do we have a problem with prefetches in this regard too. For ISD::PREFETCH I see just this:
>
>   case ISD::PREFETCH: {
>     const MemSDNode *PF = cast<MemSDNode>(N);
>     ID.AddInteger(PF->getPointerInfo().getAddrSpace());
>     break;
>   }
>   
>
> If you agree that there's also a problem here, please update this as well.


I agree, I'll update and see if I can produce a test case for it.


Repository:
  rL LLVM

https://reviews.llvm.org/D38898





More information about the llvm-commits mailing list