[lld] r316735 - Do not use InputSection::getFile<ELFT>() if InputSection::File suffices. NFC.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 26 20:25:04 PDT 2017
Author: ruiu
Date: Thu Oct 26 20:25:04 2017
New Revision: 316735
URL: http://llvm.org/viewvc/llvm-project?rev=316735&view=rev
Log:
Do not use InputSection::getFile<ELFT>() if InputSection::File suffices. NFC.
Modified:
lld/trunk/ELF/InputSection.cpp
lld/trunk/ELF/SyntheticSections.cpp
Modified: lld/trunk/ELF/InputSection.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.cpp?rev=316735&r1=316734&r2=316735&view=diff
==============================================================================
--- lld/trunk/ELF/InputSection.cpp (original)
+++ lld/trunk/ELF/InputSection.cpp Thu Oct 26 20:25:04 2017
@@ -251,7 +251,7 @@ std::string InputSectionBase::getLocatio
SrcFile = toString(File);
// Find a function symbol that encloses a given location.
- for (SymbolBody *B : getFile<ELFT>()->getSymbols())
+ for (SymbolBody *B : File->getSymbols())
if (auto *D = dyn_cast<DefinedRegular>(B))
if (D->Section == this && D->Type == STT_FUNC)
if (D->Value <= Offset && Offset < D->Value + D->Size)
Modified: lld/trunk/ELF/SyntheticSections.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SyntheticSections.cpp?rev=316735&r1=316734&r2=316735&view=diff
==============================================================================
--- lld/trunk/ELF/SyntheticSections.cpp (original)
+++ lld/trunk/ELF/SyntheticSections.cpp Thu Oct 26 20:25:04 2017
@@ -134,7 +134,7 @@ MipsAbiFlagsSection<ELFT> *MipsAbiFlagsS
Sec->Live = false;
Create = true;
- std::string Filename = toString(Sec->getFile<ELFT>());
+ std::string Filename = toString(Sec->File);
const size_t Size = Sec->Data.size();
// Older version of BFD (such as the default FreeBSD linker) concatenate
// .MIPS.abiflags instead of merging. To allow for this case (or potential
@@ -203,7 +203,7 @@ MipsOptionsSection<ELFT> *MipsOptionsSec
Sec->Live = false;
Create = true;
- std::string Filename = toString(Sec->getFile<ELFT>());
+ std::string Filename = toString(Sec->File);
ArrayRef<uint8_t> D = Sec->Data;
while (!D.empty()) {
@@ -262,14 +262,12 @@ MipsReginfoSection<ELFT> *MipsReginfoSec
Create = true;
if (Sec->Data.size() != sizeof(Elf_Mips_RegInfo)) {
- error(toString(Sec->getFile<ELFT>()) +
- ": invalid size of .reginfo section");
+ error(toString(Sec->File) + ": invalid size of .reginfo section");
return nullptr;
}
auto *R = reinterpret_cast<const Elf_Mips_RegInfo *>(Sec->Data.data());
if (Config->Relocatable && R->ri_gp_value)
- error(toString(Sec->getFile<ELFT>()) +
- ": unsupported non-zero ri_gp_value");
+ error(toString(Sec->File) + ": unsupported non-zero ri_gp_value");
Reginfo.ri_gprmask |= R->ri_gprmask;
Sec->getFile<ELFT>()->MipsGp0 = R->ri_gp_value;
More information about the llvm-commits
mailing list