[PATCH] D38898: [SelectionDAG] Add MachineMemOperand flags to the NodeID for MemSDNodes

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 19:59:45 PDT 2017


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM

Also, do we have a problem with prefetches in this regard too. For ISD::PREFETCH I see just this:

  case ISD::PREFETCH: {
    const MemSDNode *PF = cast<MemSDNode>(N);
    ID.AddInteger(PF->getPointerInfo().getAddrSpace());
    break;
  }

If you agree that there's also a problem here, please update this as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D38898





More information about the llvm-commits mailing list