[PATCH] D37660: [ScalarEvolution] Handling Conditional Instruction in SCEV chain.

[Jun Ryung Ju via Phabricator via llvm-commits]

junryoungju abandoned this revision.
junryoungju added a comment.

In https://reviews.llvm.org/D37660#908797, @chandlerc wrote:

> In https://reviews.llvm.org/D37660#904750, @junryoungju wrote:
>
> > In https://reviews.llvm.org/D37660#903417, @jbhateja wrote:
> >
> > > Few general concerns.
> > >
> > >   1/  Always submit patch with few test cases (valid for any patch).
> > >   2/  Patch https://reviews.llvm.org/D38494 is taking care of this problem. I don't see what is your point in duplicating the efforts.
> > >
> > > You are on the review list also.
> > >
> > > There is no derth of open problems to tackle. I hope you understand my point here.
> > >
> > > Thanks.
> >
> >
> > Because we are solving issue as another way.
>
>
> I see you have already joined the review of the other patch. If there is a problem with that approach, please clearly explain why and what the alternative approach would be on that patch as part of code review. Perhaps the author will wish you to provide a patch for this alternative, but it doesn't make sense to continue reviewing *both* patches in parallel. We should figure out which approach is best first, and then review the patch that uses that approach. As the other patch (https://reviews.llvm.org/D38494) seems to be quite active, I would suggest consolidating the discussion around approach on that patch.
>
> Until that is resolved, I don't think it makes sense to continue iterating in review here. It just fragments the discussion.


I am removing this from issue. I will focus on https://reviews.llvm.org/D38494 .


https://reviews.llvm.org/D37660