[PATCH] D39255: [AMDGPU] Emit metadata for hidden arguments for kernel enqueue

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUHSAMetadataStreamer.cpp:265-267
   emitKernelArg(DL, Int64Ty, ValueKind::HiddenGlobalOffsetX);
   emitKernelArg(DL, Int64Ty, ValueKind::HiddenGlobalOffsetY);
   emitKernelArg(DL, Int64Ty, ValueKind::HiddenGlobalOffsetZ);
----------------
yaxunl wrote:
> t-tye wrote:
> > Should these only be requested if there are uses of the corresponding get intrinsics along the lines of only generating the following ones if they are actually used? If not generated then the HIDDENNONE needs to be generated if necessary.
> Can we do that in a separate patch? This patch is intended for metadata for enqueue_kernel.
I have this and other minor cleanups partially completed.


https://reviews.llvm.org/D39255