[PATCH] D39264: [GISel]: Make the combiner check if shifts are legal before creating them

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added inline comments.


================
Comment at: llvm/trunk/include/llvm/CodeGen/GlobalISel/LegalizerCombiner.h:98
       unsigned SizeDiff = DstTy.getSizeInBits() - SExtSrcTy.getSizeInBits();
       auto SizeDiffMIB = Builder.buildConstant(DstTy, SizeDiff);
       unsigned TruncSrcReg = DefMI->getOperand(1).getReg();
----------------
rovka wrote:
> You forgot this G_CONSTANT :)
Fixed - r316694
Thanks


Repository:
  rL LLVM

https://reviews.llvm.org/D39264