[PATCH] D38625: [ELF] - Ignore non-absolute R_386_GOTPC relocation in debug sections.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 10:59:50 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/ELF/i386-debug-noabs.test:7-8
+## It is for PR34852 (https://bugs.llvm.org//show_bug.cgi?id=34852)
+## gcc-8.0 or earlier has a bug which creates non-absolute R_386_GOTPC 
+## relocation against _GLOBAL_OFFSET_TABLE_ when producing objects for.
+## i386 target. Here we check that LLD is able to use such objects.
----------------
This is for https://bugs.llvm.org//show_bug.cgi?id=34852. GCC 8.0 or earlier have a bug which creates non-absolute R_386_GOTPC relocations in non-allocated sections. It is illegal, but we want to make sure that lld skips them instead of reporting errors.


https://reviews.llvm.org/D38625





More information about the llvm-commits mailing list