[PATCH] D38756: [x86] use an insert op to put one variable element into a constant of vectors

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:7725
+      else if (!Elt.isUndef()) {
+        VarElt = Elt;
+        InsIndex = DAG.getConstant(i, dl, getVectorIdxTy(DAG.getDataLayout()));
----------------
assert that VarElts + InsIndex are null?


================
Comment at: test/CodeGen/X86/buildvec-insertvec.ll:74
+; SSE41-NEXT:    blendpd {{.*#+}} xmm0 = xmm0[0],mem[1]
+; SSE41-NEXT:    retq
 entry:
----------------
Add a FIXME comment to this test


https://reviews.llvm.org/D38756