[zorg] r316677 - LLVMBuilder: Remove mutable default argument, NFCI.

Jonas Hahnfeld via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 10:26:53 PDT 2017


Author: hahnfeld
Date: Thu Oct 26 10:26:53 2017
New Revision: 316677

URL: http://llvm.org/viewvc/llvm-project?rev=316677&view=rev
Log:
LLVMBuilder: Remove mutable default argument, NFCI.

See http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments

Modified:
    zorg/trunk/zorg/buildbot/builders/LLVMBuilder.py

Modified: zorg/trunk/zorg/buildbot/builders/LLVMBuilder.py
URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/LLVMBuilder.py?rev=316677&r1=316676&r2=316677&view=diff
==============================================================================
--- zorg/trunk/zorg/buildbot/builders/LLVMBuilder.py (original)
+++ zorg/trunk/zorg/buildbot/builders/LLVMBuilder.py Thu Oct 26 10:26:53 2017
@@ -20,7 +20,7 @@ def getLLVMCMakeBuildFactory(
                   enable_shared        = False,            # Enable shared (-DBUILD_SHARED_LIBS=ON configure parameters added) if true.
                   defaultBranch        = 'trunk',          # Branch to build.
                   config_name          = 'Debug',          # Configuration name.
-                  env                  = {},               # Environmental variables for all steps.
+                  env                  = None,             # Environmental variables for all steps.
                   extra_cmake_args = []):                  # Extra args for the cmake step.
     # Prepare environmental variables. Set here all env we want everywhere.
     merged_env = {




More information about the llvm-commits mailing list