[PATCH] D39327: [COFF] Support ordinals in def files with space between @ and the number
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 26 09:44:54 PDT 2017
rnk accepted this revision.
rnk added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lib/Object/COFFModuleDefinition.cpp:253
if (Tok.K == Identifier && Tok.Value[0] == '@') {
- if (Tok.Value.drop_front().getAsInteger(10, E.Ordinal)) {
+ if (Tok.Value == "@") {
+ read();
----------------
Please add a comment describing the three alternatives:
foo at 10
foo @ 10
foo\n at bar
Otherwise, looks good.
https://reviews.llvm.org/D39327
More information about the llvm-commits
mailing list