[PATCH] D39137: Add CallSiteSplitting pass

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: test/Transforms/CallSiteSplitting/callsite-split.ll:1
+; RUN: opt < %s -callsite-splitting -inline -instcombine -jump-threading -S | FileCheck %s
+; RUN: opt < %s  -passes='function(callsite-splitting),cgscc(inline),function(instcombine,jump-threading)' -S | FileCheck %s
----------------
Do we really need to run `-inline -instcombine and -jump-threading`? Wouldn't it be enough to just declare your callee functions and then just check if it has been split properly and the new call sites have the correct arguments?

Also, it might be a good idea to add a few negative tests, e.g. conditions with non-constants and so on


https://reviews.llvm.org/D39137