[PATCH] D39056: [mips] Use register scavenging with MSA.

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 08:53:12 PDT 2017


sdardis added inline comments.


================
Comment at: lib/Target/Mips/MipsFrameLowering.cpp:124
+    if (MFI.getObjectOffset(I) > 0)
+      Size = MFI.getObjectSize(I);
 
----------------
atanasyan wrote:
> So now we save to the `Size` a "positive" size of an object with minimal index. Is it intended? Should we sum all the sizes?
D'oh. Yes, that should be +=.


https://reviews.llvm.org/D39056





More information about the llvm-commits mailing list