[PATCH] D39302: Don't internalize dllexport functions.

Filipe Cabecinhas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 08:37:56 PDT 2017


filcab added a comment.

What's the meaning of (old) "norename" in thin LTO? I couldn't track it down, but it seems like it might be helpful. If it's to tell whomever imports the module that that function can't be renamed, then I think `dllexport`ed functions should be tagged as such.
I can see a case for allowing an importing module to inline `dllexport` functions without allowing it to delete the original, though. I'm not sure if norename (now `NotEligibleToImport`) allows this.

Thoughts?

Filipe


https://reviews.llvm.org/D39302





More information about the llvm-commits mailing list