[PATCH] D39255: [AMDGPU] Emit metadata for hidden arguments for kernel enqueue

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUHSAMetadataStreamer.cpp:265-267
   emitKernelArg(DL, Int64Ty, ValueKind::HiddenGlobalOffsetX);
   emitKernelArg(DL, Int64Ty, ValueKind::HiddenGlobalOffsetY);
   emitKernelArg(DL, Int64Ty, ValueKind::HiddenGlobalOffsetZ);
----------------
Should these only be requested if there are uses of the corresponding get intrinsics along the lines of only generating the following ones if they are actually used? If not generated then the HIDDENNONE needs to be generated if necessary.


https://reviews.llvm.org/D39255