[PATCH] D39245: [ADT] Shuffle containers before sorting to uncover non-deterministic behavior

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added a comment.

In https://reviews.llvm.org/D39245#907221, @chandlerc wrote:

> I don't really like the ever growing set of configuration macros here.
>
> I would much prefer we have one ABI-breaking check macro and just use that for everything here...


Thanks @chandlerc. I am fine with enabling this based on LLVM_ABI_BREAKING_CHECKS. However, this macro is ON by default for +asserts builds. This means all existing +asserts bots would start failing as soon as this patch gets merged since there are about 15 unit test failures. Do we want to gate patches if they show up sort order failures uncovered by shuffling?
My idea was to control this via a separate macro so that we can isolate shuffle+sort failures into a separate bot which may make it easier to fix without gating the regular flow. Thoughts?


Repository:
  rL LLVM

https://reviews.llvm.org/D39245