[PATCH] D39259: [lld] unified COFF and ELF error handling on new Common/ErrorHandler
Bob Haarman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 25 14:52:05 PDT 2017
inglorion added inline comments.
================
Comment at: lld/include/lld/Common/ErrorHandler.h:50-54
+ ErrorHandler(llvm::raw_ostream *Stream, StringRef LogName)
+ : ErrorLimitExceededMsg("too many errors emitted, stopping now (use "
+ "-error-limit=0 to see all errors)"),
+ LogName(LogName), ErrorOS(Stream),
+ ColorDiagnostics(Stream->has_colors()) {}
----------------
ruiu wrote:
> I believe you are not using this ctor.
The default ctor delegates to it. I suppose I could just only have a default ctor.
https://reviews.llvm.org/D39259
More information about the llvm-commits
mailing list