[PATCH] D39294: [llvm-dwarfdump] - Teach verifier to report broken DWARF expressions.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:384
+    ++NumErrors;
+    error() << TitleMsg;
+    Die.dump(OS, 0, DumpOpts);
----------------
perhaps also add the `<< ":\n"` ?


================
Comment at: test/tools/llvm-dwarfdump/X86/verify_broken_exprloc.s:12
+# VERIFY:      DW_TAG_GNU_call_site_parameter
+# VERIFY-NEXT:   DW_AT_location    (decoding error.)
+
----------------
where does the `.` after error come from? it looks out of place. Perhaps `<decoding error>` would be better?


https://reviews.llvm.org/D39294