[PATCH] D39214: [MachineModuleInfoImpls] Replace qsort with array_pod_sort
Mandeep Singh Grang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 25 11:23:34 PDT 2017
mgrang updated this revision to Diff 120287.
mgrang retitled this revision from "[MachineModuleInfoImpls] Replace qsort with std::stable_sort" to "[MachineModuleInfoImpls] Replace qsort with array_pod_sort".
mgrang edited the summary of this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D39214
Files:
lib/CodeGen/MachineModuleInfoImpls.cpp
Index: lib/CodeGen/MachineModuleInfoImpls.cpp
===================================================================
--- lib/CodeGen/MachineModuleInfoImpls.cpp
+++ lib/CodeGen/MachineModuleInfoImpls.cpp
@@ -15,8 +15,6 @@
#include "llvm/CodeGen/MachineModuleInfoImpls.h"
#include "llvm/ADT/DenseMap.h"
#include "llvm/MC/MCSymbol.h"
-#include <cstdlib>
-#include <utility>
using namespace llvm;
@@ -28,20 +26,17 @@
void MachineModuleInfoMachO::anchor() {}
void MachineModuleInfoELF::anchor() {}
-static int SortSymbolPair(const void *LHS, const void *RHS) {
- using PairTy = std::pair<MCSymbol *, MachineModuleInfoImpl::StubValueTy>;
-
- const MCSymbol *LHSS = ((const PairTy *)LHS)->first;
- const MCSymbol *RHSS = ((const PairTy *)RHS)->first;
- return LHSS->getName().compare(RHSS->getName());
+using PairTy = std::pair<MCSymbol *, MachineModuleInfoImpl::StubValueTy>;
+static int SortSymbolPair(const PairTy *LHS, const PairTy *RHS) {
+ return LHS->first->getName().compare(RHS->first->getName());
}
MachineModuleInfoImpl::SymbolListTy MachineModuleInfoImpl::getSortedStubs(
DenseMap<MCSymbol *, MachineModuleInfoImpl::StubValueTy> &Map) {
MachineModuleInfoImpl::SymbolListTy List(Map.begin(), Map.end());
if (!List.empty())
- qsort(&List[0], List.size(), sizeof(List[0]), SortSymbolPair);
+ array_pod_sort(List.begin(), List.end(), SortSymbolPair);
Map.clear();
return List;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39214.120287.patch
Type: text/x-patch
Size: 1423 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171025/45429657/attachment.bin>
More information about the llvm-commits
mailing list