[PATCH] D39264: [GISel]: Make the combiner check if shifts are legal before creating them

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 25 10:30:27 PDT 2017


aditya_nandakumar added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/LegalizerCombiner.h:71
       auto SrcCopyOrTrunc = Builder.buildAnyExtOrTrunc(DstTy, TruncSrc);
       Builder.buildAnd(DstReg, SrcCopyOrTrunc, MaskCstMIB);
       markInstAndDefDead(MI, *DefMI, DeadInsts);
----------------
rovka wrote:
> You should check the same thing for G_AND and G_CONSTANT.
Thanks. Will do it in the commit.


https://reviews.llvm.org/D39264





More information about the llvm-commits mailing list