[PATCH] D39244: [sanitizer] Random shuffling of chunks for the 32-bit Primary Allocator

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad updated this revision to Diff 120272.
cryptoad marked 12 inline comments as done.
cryptoad added a comment.

Addressing comments from the review:

- moving shuffling into `PopulateBatches`
- renaming an ambiguous variable

I also changed a couple more things:

- if using a separate class for batches, do not shuffle it (there is no user controlled allocations in the region so randomizing isn't useful);
- 32-bit primary `rand_state` initialized with `sci` rather than `this` so that 2 different classes initialized at the same time would have different seeds.


https://reviews.llvm.org/D39244

Files:
  lib/sanitizer_common/sanitizer_allocator.h
  lib/sanitizer_common/sanitizer_allocator_primary32.h
  lib/sanitizer_common/sanitizer_allocator_primary64.h
  test/scudo/random_shuffle.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39244.120272.patch
Type: text/x-patch
Size: 6119 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171025/dc9c0b10/attachment.bin>