[PATCH] D39056: [mips] Use register scavenging with MSA.

[Simon Dardis via Phabricator via llvm-commits]

sdardis added inline comments.


================
Comment at: lib/Target/Mips/MipsFrameLowering.cpp:119
   for (int I = MFI.getObjectIndexBegin(); I != 0; ++I)
-    Offset = std::max(Offset, -MFI.getObjectOffset(I));
+    Offset = std::max(Offset, MFI.getObjectOffset(I));
 
----------------
atanasyan wrote:
> Was the initial expression with `-` sign a bug/typo?
I thought this was a bug, but it's not quite.

This function was estimating the size of the stack, but doesn't account for incoming arguments. MachineFrameInfo::estimateStackSize() perfroms most of the calculations here, but doesn't account for fixed objects which represent incoming arguments or spilling all callee-saved registers.

I'll update this shortly.


Repository:
  rL LLVM

https://reviews.llvm.org/D39056