[PATCH] D39000: [ELF] - Implement --orphan-handling option.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/ELF/linkerscript/orphan-report.s:46-48
+# RUN: not ld.lld --orphan-handling=discard -o %t.out --script %t.script %t.o 2>&1 \
+# RUN:   | FileCheck %s --check-prefix=UNKNOWN
+# UNKNOWN: unknown --orphan-handling mode: discard
----------------
ruiu wrote:
> In general, when you give a bogus value, you should give a value that is obviously bogus, because it conveys your meaning better. Instead of "discard", pass "foo", for example. This comment applies to other patches.
I passed "discard" here intentionally to document that we do not support this mode explicitly.
I can change to "foo" case as well, but I supposed "discard" case is useful itself.


https://reviews.llvm.org/D39000