[PATCH] D39278: [lit] Respect LLVM_LIT_TOOLS_DIR when looking for 'tar' on Windows.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: test/lit.cfg.py:90
+        [tar_executable, '--version'], stdout=subprocess.PIPE, env={'LANG': 'C'})
+    if 'GNU tar' in tar_version.stdout.read().decode():
+        config.available_features.add('gnutar')
----------------
lichray wrote:
> How about just read with `tar_version, _ = communicate()` and remove the '.wait()'?
I'd redirect your idea to the author of D38977, @pcc.
Anyway, this patch is only about fixing an execution failure on Windows, and nothing more.


Repository:
  rL LLVM

https://reviews.llvm.org/D39278