[PATCH] D38973: COFF: Give manifest resource file a name.

Tue Oct 24 22:02:14 PDT 2017

pcc added a comment.

In https://reviews.llvm.org/D38973#902432, @pcc wrote:

> In https://reviews.llvm.org/D38973#902376, @thakis wrote:
>
> > > because this requires Windows an
> >
> > Why does this require Windows? lld does manifest stuff natively nowadays, so this should be testable on non-Windows I think.
>
>
> That's true. Our implementation of the Windows maniifest tool appears to require libxml, so I suppose we could gate the test on the libxml2 feature. We might also want to do something like https://reviews.llvm.org/D38977 to test this on Windows as well.

I ended up adding a test for this commit in https://reviews.llvm.org/rL316547.

Repository:
  rL LLVM

https://reviews.llvm.org/D38973