[PATCH] D38975: COFF: Don't add /manifest* flags to the response file.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 24 22:01:21 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL316547: COFF: Don't add /manifest* flags to the response file. (authored by pcc).

Changed prior to commit:
  https://reviews.llvm.org/D38975?vs=119214&id=120185#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D38975

Files:
  lld/trunk/COFF/Driver.cpp
  lld/trunk/test/COFF/linkrepro-manifest.test


Index: lld/trunk/test/COFF/linkrepro-manifest.test
===================================================================
--- lld/trunk/test/COFF/linkrepro-manifest.test
+++ lld/trunk/test/COFF/linkrepro-manifest.test
@@ -0,0 +1,12 @@
+REQUIRES: x86, gnutar, manifest_tool
+
+RUN: rm -rf %t && mkdir %t
+RUN: lld-link -entry:__ImageBase -nodefaultlib -linkrepro:%t -manifest:embed %p/Inputs/std32.lib -subsystem:console
+RUN: tar tf %t/repro.tar | FileCheck --check-prefix=LIST %s
+RUN: tar xOf %t/repro.tar repro/response.txt | FileCheck %s
+
+LIST: manifest.res
+
+CHECK-NOT: -manifest
+CHECK: .manifest.res
+CHECK-NOT: -manifest
Index: lld/trunk/COFF/Driver.cpp
===================================================================
--- lld/trunk/COFF/Driver.cpp
+++ lld/trunk/COFF/Driver.cpp
@@ -410,6 +410,12 @@
     case OPT_INPUT:
     case OPT_defaultlib:
     case OPT_libpath:
+    case OPT_manifest:
+    case OPT_manifest_colon:
+    case OPT_manifestdependency:
+    case OPT_manifestfile:
+    case OPT_manifestinput:
+    case OPT_manifestuac:
       break;
     default:
       OS << toString(Arg) << "\n";


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38975.120185.patch
Type: text/x-patch
Size: 1117 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171025/da846b27/attachment.bin>


More information about the llvm-commits mailing list