[lld] r315673 - Make it explicit that we are writing addends to target sections if REL.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 24 20:45:46 PDT 2017
I'll fix it.
On Tue, Oct 24, 2017 at 8:58 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:
> Rui Ueyama via llvm-commits <llvm-commits at lists.llvm.org> writes:
>
> > + // If the produced value is a constant, we just remember to write it
> > + // when outputting this section. We also have to do it if the format
> > + // uses Elf_Rel, since in that case the written value is the addend.
> > + if (IsConstant) {
> > + Sec.Relocations.push_back({Expr, Type, Offset, Addend, &Body});
> > + continue;
> > + }
>
> This Elf_Rel comment is now out of sync with the code, no?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171024/2170c2fd/attachment.html>
More information about the llvm-commits
mailing list