[PATCH] D38665: [CMake] Fix linker detection in AddLLVM.cmake

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

CMake inherently runs on a variety of systems, so if your change could result in producing a head-scratching mysterious error message on some system, I think you need to address that from the beginning, even if that system is not supported. Saying that "this flag is not supported/your system is too old" is one of essential roles of our cmakefiles and that is not "good to have".

That said, since we already have a check for a LLVM_USE_LINKER value in llvm/cmake/modules/HandleLLVMOptions.cmake, it seems that we don't need add the same check to this file. So LGTM.

(Actually, the existing check in HandleLLVMOptions.cmake is not working because of a bug, so when you pass a bogus value to -DLLVM_USE_LINKER, it prints out a bad error message. I'll fix it separately.)


Repository:
  rL LLVM

https://reviews.llvm.org/D38665