[PATCH] D39260: [asan] Don't print rows of shadow bytes outside shadow memory

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/asan/asan_errors.cc:429
+    // space.
+    if (!AddrIsInShadow(row_shadow_addr)) continue;
     const char *prefix = (i == 0) ? "=>" : "  ";
----------------
rnk wrote:
> vitalybuka wrote:
> > What do users see now, without your patch?
> A crash, the shadow below is unmapped.
Maybe some placeholder would be nice, to show that shadow is missing.
Still it's improvement as is.


https://reviews.llvm.org/D39260