[PATCH] D38654: Parse DWARF information to reduce false positives.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: tools/llvm-cfi-verify/lib/FileAnalysis.cpp:54
+        "will result in false positives for 'CFI unprotected' instructions."),
+    cl::location(IgnoreDWARF), cl::init(false));
+
----------------
I don't think you need `cl::location` or the external declaration of `IgnoreDWARF`, because this flag is only used in this file.


================
Comment at: unittests/tools/llvm-cfi-verify/FileAnalysis.cpp:485
 
+TEST_F(BasicFileAnalysisTest, CFIProtectionInvalidTargets) {
+  if (!SuccessfullyInitialised)
----------------
Am I missing something, or should these new tests include DWARF information?


https://reviews.llvm.org/D38654