[PATCH] D39249: Add support for e500mc extpid instructions

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrInfo.td:3940
+                      "lbepx $rD, $src", IIC_LdStLoad,
+                      [(set i32:$rD, (zextloadi8 xaddr:$src))]>,
+                      Requires<[IsE500]>;
----------------
vit9696 wrote:
> hfinkel wrote:
> > You have patterns on a bunch of these? Do you intend to add code-generation support for these instructions, or just assembler/disassembler support? If the latter, remove the patterns.
> According to the docs these instructions behave the same way at the non-extpid ones, so I tried to preserve as much information as possible. I don't think one could be able to use them in normal C (they are all privileged and specific), but if someone decides to add the  intrinsics sooner or later it might help.
> If you are think it is better to leave them out (I personally do not need anything but inline/outline asm/disasm), then I am fine with it. Could group stuff (e.g. PPC970_DGroup_Single) be also taken out in this case?
> I don't think one could be able to use them in normal C (they are all privileged and specific), but if someone decides to add the intrinsics sooner or later it might help.

In that case, they shouldn't have patterns (because we might get them from instruction selection in normal C code). Please remove the patterns.

> Could group stuff (e.g. PPC970_DGroup_Single) be also taken out in this case?

Yes, you can leave those out as well (it's meaningless in this context).



https://reviews.llvm.org/D39249