[PATCH] D39140: LLD/ELF/AMDGPU: Process AMDGPU-specific e_flags

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 24 10:58:31 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

Yes, when you complete your other changes, please replace the file. LGTM



================
Comment at: ELF/Arch/AMDGPU.cpp:51
+    if (Ret != cast<ObjFile<ELF64LE>>(F)->getObj().getHeader()->e_flags) {
+      error("incompatible e_flags: " + F->getName());
+      return 0;
----------------
toString(F) is better than F->getName() because an archive file name is included in the former output if F was pulled out from an archive.


https://reviews.llvm.org/D39140





More information about the llvm-commits mailing list