[PATCH] D39088: [AArch64][SVE] Asm: Replace 'IsVector' by 'RegKind' in AArch64AsmParser (NFC)

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:813
+
+  bool isNeonVectorReg() const {
+    return Kind == k_Register && Reg.Kind == RegKind::NeonVector;
----------------
sdesmalen wrote:
> rengolin wrote:
> > Is there a situation (in the future) that we might want?
> > 
> >     bool isVector() const { return Kind == k_Register && !Reg.isScalar; }
> At the moment I haven't found such a situation yet (even when considering other SVE assembler/disassembler patches) and I would rather not add code that isn't used anywhere.
> So I suggest adding that only when needed.
Makes sense


https://reviews.llvm.org/D39088