[PATCH] D39089: [AArch64][SVE] Asm: Add SVE (Z) Register definitions and parsing support

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 24 10:06:29 PDT 2017


sdesmalen added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:411
+
+    if (Kind == k_SVERegister)
+      return SVEReg.RegOpnd.RegNum;
----------------
rengolin wrote:
> I'm assuming this will change back, as you're making this an actual `k_Register` with a different type, so I'll stop reviewing for now.
Not sure I fully understand what you mean with 'changing back' into a k_Register, but to clarify my change, I  made it a separate k_SVERegister on purpose since it will be extended in future patches with attributes like shift/extend amount and element width.


https://reviews.llvm.org/D39089





More information about the llvm-commits mailing list