[lld] r315664 - Add comment.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 24 09:29:04 PDT 2017
Rui Ueyama <ruiu at google.com> writes:
>> > + // Weak undefined symbols shouldn't fetch archive members (for
>> > + // compatibility with other linkers), but we still want to memorize
>> > + // that there are lazy symbols, because strong undefined symbols
>> > + // could be added later which triggers archive member fetching.
>> > + // Thus, the weak lazy symbol is a valid concept in lld.
>> > + return !isLocal() && symbol()->isWeak() && (isUndefined() ||
>> isLazy());
>>
>> This comment is now duplicated with the one in
>> SymbolTable::addLazyArchive. Any thoughts on merging the two?
>>
>
> Maybe we can move the comment to Symbols.h to describe the semantics of the
> lazy and undefined symbols.
Done in r316455.
Cheers,
Rafael
More information about the llvm-commits
mailing list