[PATCH] D39016: Add Percent Symbol In PPC Registers for Linux

[Joerg Sonnenberger via Phabricator via llvm-commits]

joerg added a comment.

Almost.



================
Comment at: lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp:490
+/// printRegisterWithPercentPrefix - Print register with percent and prefixes.
+void printRegisterWithPercentPrefix(const char *RegName, raw_ostream &O) {
+  switch (RegName[0]) {
----------------
Should be a `static bool showRegistersWithPercentPrefix(RegName(const char *RegName)` member of PPCInstPrinter and just return true or false.


================
Comment at: lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp:537
+      }
+    }
 
----------------
...and here `if (showRegistersWithPercentPrefix(RegName) O << "%";`. Rest of the RegName logic can remain.


https://reviews.llvm.org/D39016