[PATCH] D39238: [ARM] Tighten up CHECK lines in a test

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 24 06:26:32 PDT 2017


olista01 created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.

These tests checked for the line number without a leading ":", so for example, a missed diagnostic on line 123 could match one on line 1123, 2123, etc, desynchronising the test for hundreds of lines.

This couldn't cause it to incorrectly pass or fail, but made it hard to track down test failures.


Repository:
  rL LLVM

https://reviews.llvm.org/D39238

Files:
  test/MC/ARM/v8_IT_manual.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39238.120061.patch
Type: text/x-patch
Size: 367842 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171024/222c63e3/attachment-0001.bin>


More information about the llvm-commits mailing list