[PATCH] D39181: [MemDep] DBG intrinsics don't impact abort limit for call site dependence analysis

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: test/Transforms/DeadStoreElimination/mda-with-dbg-values.ll:44
+!7 = !DILocation(scope: !5)
+!8 = !DIExpression(DW_OP_LLVM_fragment, 0, 8)
+
----------------
uabelho wrote:
> efriedma wrote:
> > Did you hand-edit this debug info?  It's missing pieces I would normally expect (specifically, the function doesn't have any debug info), so I'm not sure it's really valid.  I'd prefer if you would just use debug info generated by clang so it's likely correct.
> Yes, I've hand edited it. Originally I found this with my out-of-tree frontend/backend and the example was huge. Then I've hand reduced it as much as I could without having opt complain about the input, since I thought that the only important thing with respect to the bugfix was that the single dbg.value affected the output.
Do you prefer the updated version?


https://reviews.llvm.org/D39181