[PATCH] D39192: [ARM] processInstruction must return true if it makes a change

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 23 14:53:30 PDT 2017


olista01 added a comment.

It will probably take me a while to get the patch that uncovers this out, as it's quite complex (adding optional operands in the asm matcher, to remove some hacks like shouldOmitCCOutOperand in the asm parser and get more precise diagnostics), and I'm only working on this as a side project. Since this "bug" isn't observable at the moment I'm fine to leave this in review until the optional operands patch is published, so that it's clear why it is necessary. However, I think it should still be a separate patch, as it's not really related to the optional operands change, and would need to go in before it to avoid test failures.


Repository:
  rL LLVM

https://reviews.llvm.org/D39192





More information about the llvm-commits mailing list