[PATCH] D39194: [ARM] Include operand class name in dev diags

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 23 14:49:51 PDT 2017


rengolin added a comment.

In https://reviews.llvm.org/D39194#904288, @olista01 wrote:

> Why do you think this should be kept downstream? It's a debug option which I've found useful while adding diagnostics for assembly options, none of which I plan on keeping downstream.


Because it's an unusual pattern for assembly parsers in general and it may confuse the end user if they happen to build in assert/debug mode.

End user facing messages should be always the same. If you want a debug message, use `DEBUG()`.


Repository:
  rL LLVM

https://reviews.llvm.org/D39194





More information about the llvm-commits mailing list