[PATCH] D39137: Add CallSiteSplitting pass

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml added inline comments.


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:473
+  if (OptLevel > 2)
+    MPM.add(createCallSiteSplittingPass());
+
----------------
davidxl wrote:
> should this be moved after CFG simplification pass ? The latter may undo the splitting.
This patch will split a call-site into two call-sites with different arguments. So, I doubt if SimplifyCFG can merge it back. Moreover, if SimpliyCFG cannot merge this back, then don't you think we need to somehow merge the call-site split in this pass back to original  in later pass in case when not inlined? 

Regarding the pass order,  I think we need to place this pass even before  constant propagation to allow more  propagation.  




https://reviews.llvm.org/D39137